Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add crawler to track portal view count for portal articles #370

Merged
merged 14 commits into from
Feb 6, 2024
Merged

Add crawler to track portal view count for portal articles #370

merged 14 commits into from
Feb 6, 2024

Conversation

retroinspect
Copy link
Contributor

@retroinspect retroinspect commented Feb 8, 2023 •
edited
Loading

관련 티켓

Refactor/Feature

  • 새로운 포탈 공지글 크롤링 시 포탈 조회수를 저장하도록 수정
  • 지난 일주일간의 모든 포탈 공지글을 크롤링하여 최신 조회수를 저장하는 크롤러 추가

@retroinspect retroinspect requested a review from injoonH February 8, 2023 14:18
@retroinspect retroinspect self-assigned this Feb 8, 2023
@retroinspect retroinspect marked this pull request as ready for review February 8, 2023 14:34
retroinspect
retroinspect commented Feb 15, 2023
View reviewed changes
apps/core/models/portal_view_count.py Outdated

created_at = models.DateTimeField(
default=timezone.now,
db_index=True,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index 불필요함

@ddungiii
Copy link
Member

lgtm...

@retroinspect retroinspect force-pushed the refactor/portal-view-crawling branch from 9eb9fc1 to 63628a8 Compare January 9, 2024 14:29
@retroinspect retroinspect requested a review from ddungiii January 9, 2024 14:39
ddungiii
ddungiii reviewed Jan 16, 2024
View reviewed changes
apps/core/management/scripts/portal_crawler.py Outdated Show resolved Hide resolved
apps/core/migrations/0058_merge_20240109_2331.py
Comment on lines +1 to +12
# Generated by Django 4.2.7 on 2024-01-09 14:31

from django.db import migrations


class Migration(migrations.Migration):
dependencies = [
("core", "0046_alter_portal_crawl_related_field"),
("core", "0057_alter_article_name_type_and_more"),
]

operations = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얜 뭐하는 애죠

@ddungiii
Copy link
Member

merge 되면 new-ara-dx 레포에 api/.env.example 업데이트 필요

업데이트 후 dx 다시 pull 받고 PORTAL_JSESSIONID 환경변수 추가하고, api container 다시 띄워야함
(docker restart는 안되더라 docker compose up 해야함)

@retroinspect retroinspect requested a review from ddungiii February 6, 2024 12:16
@retroinspect
Copy link
Contributor Author

최종 Approve 부탁드려요~ @ddungiii @injoonH

@retroinspect retroinspect merged commit c73f252 into develop Feb 6, 2024
1 check passed
@ddungiii ddungiii mentioned this pull request Feb 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddungiii ddungiii ddungiii approved these changes

@injoonH injoonH Awaiting requested review from injoonH

Assignees

@retroinspect retroinspect

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@retroinspect @ddungiii