Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter for archive files in generate_appcast more intelligently #2448

Merged
merged 3 commits into from
Oct 8, 2023

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented Oct 1, 2023

Related to discussion #2447

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested that archive files are still included and non-archive files are not included.

macOS version tested: 14.0 (23A344)

@zorgiepoo zorgiepoo added this to the 2.5.1 milestone Oct 1, 2023
@zorgiepoo zorgiepoo changed the title Don't treat extensionless files as archives in generate_appcast Filter for archive files in generate_appcast more intelligently Oct 8, 2023
@zorgiepoo zorgiepoo merged commit bd90fb7 into 2.x Oct 8, 2023
2 checks passed
@zorgiepoo zorgiepoo deleted the ignore-extensionless-feed branch October 8, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant