Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GHA libraries to use modern NodeJS runtime #2451

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

jozefizso
Copy link
Contributor

As the node12 runtime is deprecated by GitHub Actions this PR updates workflow actions to latest versions which use node16 and/or node20.

The PR comment action was changed to use the GITHUB_TOKEN with pull-requests: write permission instead of the BOT PAT.

Fixes # (issue)

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested on GitHub Actions.

This removes the warning about the deprecated `node12` runtime used by existing actions.
The v2 action uses `node16` runtime
Workflow will use the `GITHUB_TOKEN` with `pull-requests: write` permission instead of PAT
@zorgiepoo zorgiepoo added this to the 2.6 milestone Oct 15, 2023
@zorgiepoo
Copy link
Member

Thank you. Ran tests with the archive being uploaded and warnings being posted in #2456.

@zorgiepoo zorgiepoo merged commit a00fd1d into sparkle-project:2.x Oct 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants