Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use crc32 hashes for binary delta version 4 #2638

Merged
merged 11 commits into from
Oct 13, 2024
Merged

Use crc32 hashes for binary delta version 4 #2638

merged 11 commits into from
Oct 13, 2024

Conversation

zorgiepoo
Copy link
Member

Use CRC32 hashes for before/after bundle hashes for version 4 format, which is more efficient than SHA1.

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested applying binary delta version 4 patch (with BinaryDelta) on:
macOS 15.0 (24A335)
macOS 10.14 VM

Tested creating/applying binary delta version 3 patch still works (with BinaryDelta)

@zorgiepoo zorgiepoo added this to the 2.7 milestone Sep 30, 2024
@zorgiepoo zorgiepoo merged commit 14ba9ef into 2.x Oct 13, 2024
2 checks passed
@zorgiepoo zorgiepoo deleted the crc32-hash branch October 13, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant