Use crc32 hashes for binary delta version 4 #2638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CRC32 hashes for before/after bundle hashes for version 4 format, which is more efficient than SHA1.
Misc Checklist
Testing
I tested and verified my change by using one or multiple of these methods:
Tested applying binary delta version 4 patch (with BinaryDelta) on:
macOS 15.0 (24A335)
macOS 10.14 VM
Tested creating/applying binary delta version 3 patch still works (with BinaryDelta)