Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore type hints in undecorated parsed function calls #1833

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Ignore type hints in undecorated parsed function calls #1833

merged 1 commit into from
Dec 23, 2024

Conversation

tbennun
Copy link
Collaborator

@tbennun tbennun commented Dec 22, 2024

Fixes cases in which the user has no control over undecorated nested function calls, which previously led to unclear and unrelated pyobject type errors.

@tbennun tbennun requested a review from phschaad December 22, 2024 08:35
phschaad
phschaad approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@phschaad phschaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@phschaad phschaad added this pull request to the merge queue Dec 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 23, 2024
@phschaad phschaad added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 65ca11f Dec 23, 2024
9 checks passed
@phschaad phschaad deleted the nested-hints branch December 23, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phschaad phschaad phschaad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbennun @phschaad