Skip to content

Commit

Permalink
Minor updates
Browse files Browse the repository at this point in the history
  • Loading branch information
mcopik committed Jul 29, 2021
1 parent f23f64e commit 7b25c3c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ dependencies and information on allocated cloud resources.
Benchmarks will be rebuilt after a change in source code is detected.
To enforce redeployment of code and benchmark input please use flags `--update-code`
and `--update-storage`, respectively.
**Note:** the cache does not support updating cloud region. If you want to deploy benchmarks
to a new cloud region, then use a new cache directory.

### Benchmark

Expand Down
2 changes: 1 addition & 1 deletion sebs/azure/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,8 @@ def deserialize(config: dict, cache: Cache, handlers: LoggingHandlers) -> Config
else:
config_obj.logging.info("Using user-provided config for Azure")
AzureConfig.initialize(config_obj, config)
resources.set_region(config_obj.region)

resources.set_region(config_obj.region)
return config_obj

"""
Expand Down
2 changes: 2 additions & 0 deletions sebs/gcp/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,8 @@ def deserialize(config: dict, cache: Cache, handlers: LoggingHandlers) -> "Confi
["region", ["gcp", "region"]], # type: ignore
["project_name", ["gcp", "project_name"]], # type: ignore
]
# for each attribute here, check if its version is different than the one provided by
# user; if yes, then update the value
for config_key, keys in updated_keys:

old_value = getattr(config_obj, config_key)
Expand Down

0 comments on commit 7b25c3c

Please sign in to comment.