Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspaces): add workspaceRole to LimitedUser type #3721

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cdriesler
Copy link
Member

Description & motivation

  • The invite flow needs to check if a given LimitedUser from a user search is already a member of a known workspace

Changes:

  • Adds workspaceRole to LimitedUser type, modeled after workspaceDomainPolicyCompliant

@cdriesler cdriesler requested a review from alemagio December 18, 2024 19:05
@iainsproat
Copy link
Contributor

On the philosophy that there are no stupid questions, I'll ask some 😉 :

Are there restrictions on who can query for LimitedUser?

Does the user running the query need to be a member of the workspace in order to see whether the returned LimitedUser is a member of the workspace? i.e. what's stopping a leak of all the workspace membership of users? (which is commercially sensitive info)

Copy link
Contributor

@iainsproat iainsproat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like a clearer description in the PR of the security/confidentiality implications before we merge.

@cdriesler cdriesler removed the request for review from alemagio January 7, 2025 01:04
@cdriesler
Copy link
Member Author

Ready for re-review. We now assert that users who query LimitedUser.workspaceRole(workspaceId) are at least members of the given workspace.

With this change, there shouldn't be any security implications. This is parity with current data access, just visible another way. (Workspace members can see peoples' roles)

@cdriesler cdriesler requested a review from iainsproat January 7, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants