-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server/objects): new column to track object size #3750
Draft
iainsproat
wants to merge
9
commits into
main
Choose a base branch
from
iain/web-1271-record-write-size
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removes unused methods
- this will cause slow startup for un-backfilled databases with large object tables
The migration takes too long, so we need to move the backfill to a different process. Either a background worker on the monolith, or a separate microservice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Through memoization of the stored object size during upload of objects, we can store the data for later analysis of the size of objects.
This enables future features, such as calculating largest projects by stored size, rate of change of stored object size, averages of object size etc. etc..
NB approximate, as it JSON stringifies the object and then grossly assumes one string character to one byte.
Changes:
objects
tablesizeBytes
column is a big int data type, is nullable, and defaults to nullTo-do before merge:
Screenshots:
Validation of changes:
Checklist:
References