Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): ProjectVersionsUpdatedMessage.modelId always filled #3754

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

fabis94
Copy link
Contributor

@fabis94 fabis94 commented Jan 2, 2025

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@JR-Morgan
Copy link
Member

Hold off merge until @gjedlicska has had a chance to look please

@fabis94 fabis94 requested a review from gjedlicska January 6, 2025 08:13
@fabis94 fabis94 merged commit ab9e8bb into main Jan 6, 2025
26 of 28 checks passed
@fabis94 fabis94 deleted the fabians/project-versions-updated-modelid branch January 6, 2025 08:37
@gjedlicska
Copy link
Contributor

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants