fix(Revit): DirectShape Instances to Speckle Conversion support #3572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdbroughton
changed the title
AlanRynne
reviewed
Sep 13, 2024
@AlanRynne > Ultimately, as this the nested GeometryInstance handling is recursive if a GeometryInstance, the method will still only return a Mesh or a Solid, never a GeometryInstance itself. |
|
This fix will never make it to v2 i suppose. nevertheless, it might be of interest to whoever owns the v3 Revit @clairekuang @oguzhankoral |
JR-Morgan
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DirectShape Geometry instances are nested Mesh and Solid within a GeometryInstance objetc. Previous conversion had switch case handlers only for the geometry types, this adds a recursion to cater for nested instances.