Merge pull request #29 from spglib/python/len

Use uv in CI
spglib · Dec 9, 2024 · c86ec61 · c86ec61
2 parents c0a6e4a + f5e9878
commit c86ec61
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 22 deletions.
diff --git a/.github/workflows/ci-python.yaml b/.github/workflows/ci-python.yaml
@@ -24,6 +24,8 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: Swatinem/rust-cache@v2
+      - name: Install uv
+        uses: astral-sh/setup-uv@v3
       - uses: actions/setup-python@v4
         with:
           python-version: '3.10'
@@ -43,8 +45,8 @@ jobs:
         shell: bash
         run: |
           set -e
-          pip install moyopy --no-index --find-links dist
-          pip install moyopy[interface]
+          uv pip install --system --no-index --find-links dist moyopy
+          uv pip install --system moyopy[interface]
           python moyopy/examples/basic.py
           python moyopy/examples/pymatgen_structure.py
 
@@ -56,6 +58,8 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: Swatinem/rust-cache@v2
+      - name: Install uv
+        uses: astral-sh/setup-uv@v3
       - uses: actions/setup-python@v4
         with:
           python-version: '3.10'
@@ -76,24 +80,25 @@ jobs:
         shell: bash
         run: |
           set -e
-          pip install moyopy --no-index --find-links dist
-          pip install moyopy[testing]
+          uv pip install --system --no-index --find-links dist moyopy
+          uv pip install --system moyopy[testing]
           pytest -v
-      - name: pytest
-        if: ${{ !startsWith(matrix.target, 'x86_64') }}
-        uses: uraimo/run-on-arch-action@v2
-        with:
-          arch: ${{ matrix.target }}
-          distro: ubuntu22.04
-          githubToken: ${{ github.token }}
-          install: |
-            apt-get update -q -y
-            apt-get install -y --no-install-recommends gcc-aarch64-linux-gnu build-essential python3 python3-dev python3-pip
-          run: |
-            set -e
-            pip3 install moyopy --no-index --find-links dist
-            pip3 install moyopy[testing]
-            pytest -v
+      # TODO: too long to build...
+      # - name: pytest
+      #   if: ${{ !startsWith(matrix.target, 'x86_64') }}
+      #   uses: uraimo/run-on-arch-action@v2
+      #   with:
+      #     arch: ${{ matrix.target }}
+      #     distro: ubuntu22.04
+      #     githubToken: ${{ github.token }}
+      #     install: |
+      #       apt-get update -q -y
+      #       apt-get install -y --no-install-recommends gcc-aarch64-linux-gnu build-essential python3 python3-dev python3-pip
+      #     run: |
+      #       set -e
+      #       pip install --no-index --find-links dist moyopy
+      #       pip install moyopy[testing]
+      #       pytest -v
 
   windows:
     runs-on: windows-latest
@@ -103,6 +108,8 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: Swatinem/rust-cache@v2
+      - name: Install uv
+        uses: astral-sh/setup-uv@v3
       - uses: actions/setup-python@v4
         with:
           python-version: '3.10'
@@ -122,7 +129,7 @@ jobs:
         shell: bash
         run: |
           set -e
-          pip install -e moyopy[dev] --find-links dist --force-reinstall
+          uv pip install --system --find-links dist --force-reinstall -e moyopy[dev]
           cd moyopy && pytest -v
 
   macos:
@@ -133,6 +140,8 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: Swatinem/rust-cache@v2
+      - name: Install uv
+        uses: astral-sh/setup-uv@v3
       - uses: actions/setup-python@v4
         with:
           python-version: '3.10'
@@ -152,7 +161,7 @@ jobs:
         shell: bash
         run: |
           set -e
-          pip install -e moyopy[dev] --find-links dist --force-reinstall
+          uv pip install --system --find-links dist --force-reinstall -e moyopy[dev]
           cd moyopy && pytest -v
 
   sdist:

diff --git a/moyopy/python/tests/test_symmetry_data.py b/moyopy/python/tests/test_symmetry_data.py
@@ -22,6 +22,8 @@ def _is_close(site1, site2):
 
 def test_operations_from_number():
     operations = operations_from_number(number=230)  # Ia-3d
-    assert operations.num_operations == 48 * 2
+    num_operations = 48 * 2
+    assert operations.num_operations == num_operations
+    assert len(operations) == num_operations
 
     assert len(_unique_sites_in_cell([1 / 8, 1 / 8, 1 / 8], operations)) == 16
diff --git a/moyopy/src/base.rs b/moyopy/src/base.rs
@@ -161,6 +161,10 @@ impl PyOperations {
     pub fn num_operations(&self) -> usize {
         self.0.num_operations()
     }
+
+    fn __len__(&self) -> usize {
+        self.0.num_operations()
+    }
 }
 
 impl From<PyOperations> for Operations {