Use Zeus to run integration tests on CI #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
run-zeus-on-ci
branch
7 times, most recently
from
3466b91 to
94163fb
Compare
This vastly decreases the amount of time it takes to run CI. For instance, the "Run tests" job in a single workflow goes from ~7 minutes to ~1.75 minutes.
mcmire
force-pushed
the
run-zeus-on-ci
branch
from
94163fb to
1f0f6a7
Compare
mcmire
added a commit
that referenced
this pull request
Feb 5, 2024
This reverts commit 9e46160. Unfortunately, Zeus is just not reliable enough to run on CI. It's not even reliable locally. Sometimes tests will hang for no reason, and sometimes Zeus will fail with errors like `read unix ->: recvmsg: message too long`. And unfortunately, once Zeus fails, the best way to fix it is to restart it. This isn't possible to do in CI tests, and adding some kind of "with Zeus, then without Zeus" strategy to tests would add complexity I don't want. I'll have to find a better way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This vastly decreases the amount of time it takes to run CI. For instance, the "Run tests" job in a single workflow goes from ~7 minutes to ~1.75 minutes.