-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate deploy with GHA #946
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #946 +/- ##
=========================================
Coverage 91.65% 91.65%
Complexity 252 252
=========================================
Files 26 26
Lines 947 947
Branches 71 71
=========================================
Hits 868 868
Misses 52 52
Partials 27 27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a nice process.
I suppose we have to select the branch when running the workflow. It's more convenient to run on master/main
but that will probably mean we can't enable the branch protection rule.
If we want this extra security, we should create a release/vX.Y.Z
branch, run the action from this one and then create a pull-request and a merge
commit in the main branch
MAVEN_GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }} | ||
# Todo - remove dry-run flag once validated in GHA | ||
run: | | ||
export GPG_TTY=$(tty) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this required ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was for me, at least locally
release: | ||
name: Release | ||
runs-on: 'ubuntu-latest' | ||
environment: main_env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have an environment ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...Good question, the environment had already been created in GHA settings and is used in maven.yml so I just continued that pattern
oh, interesting idea! the only problem is that I don't know if the maven-release-plugin is sophisticated enough for this, but I can look into it |
Tested with dry-run and snapshot builds locally. I set the
-DdryRun=true
flag in the workflow build for now, so that we can run a test on GHA. Then we can remove the flag