Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JM to have more than 1 replicas #412

Closed
wants to merge 1 commit into from
Closed

Conversation

jto
Copy link
Contributor

@jto jto commented Jun 2, 2022

In a HA setup, one may want to have more than 1 JM replica.
fixes #256

Copy link

@martinbomio martinbomio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jto do you know if this has any implications? What happens in setups where there's no HA?

@jto jto force-pushed the julien/allow-jm-replicas branch from 0b48124 to be4bac7 Compare June 2, 2022 15:10
@jto jto marked this pull request as draft June 2, 2022 15:11
@jto
Copy link
Contributor Author

jto commented Jun 2, 2022

@martinbomio I'll need to test it on our dev cluster.

@jto
Copy link
Contributor Author

jto commented Jun 2, 2022

Thinking about it I think the service will load balance between the JMs which is probably a terrible thing to do.
Maybe HA should be supported by the operator directly (as in high-availability: true) and not something you set up "manually". At the same time, if you explicitly ask for the JM to have more than 1 replica, maybe you know what you're doing.

@regadas wdyt ?

@regadas
Copy link
Contributor

regadas commented Jun 3, 2022

Hm, right... maybe we could just add the required props for HA automatically when setting replicas >1? keeping the default value as 1 and then be clear of the behavior in docs. wdyt?

@jto
Copy link
Contributor Author

jto commented Jun 3, 2022

@regadas Yep that's what I was thinking too.

@jto jto closed this Feb 14, 2023
@martinbomio
Copy link

@jto @regadas do we have an issue to track this festure request? If we don't, I can create one given this is still relevant

@regadas
Copy link
Contributor

regadas commented Feb 15, 2023

I think this one is a bit related #256. But feel free to open a new one if you feel it doesn't capture it all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error setting up HA for JobManager
3 participants