Add jsonReader and jsonWriter functions for constructing readers and writers for case classes #246
+81
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There are functions like
jsonFormat3
that createJsonFormat
objects for case classes. Sometimes you need only readers or writers, because you are developing client or server side of an api. There is no problem,JsonFormat
extends both. But there are situations when you have your type with custom serialisation logic, eg. serialisingsealed trait
, and you are developing eg. only api server side. So in such situations it would be good to define only writers for your's case classes in order to avoid defining unnecessaryread
function for your exemplarysealed trait
. This PR provides such functions, analogous tojsonFormat
familly.This PR doesn't provide any new tests, because
jsonFormat
functions have been refactored and they use new functions internally, soProductFormatsSpec
tests new functions as well.