Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving CF deployer documentation #868

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Conversation

Albertoimpl
Copy link
Member

Adding stack as a suported property

Adding stack as a suported property
spikymonkey
spikymonkey previously approved these changes Oct 2, 2023
Copy link
Contributor

@spikymonkey spikymonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Albertoimpl! Should we take the opportunity to sort the rows in this table? It feels a bit random at the moment.

@Albertoimpl
Copy link
Member Author

I like the idea, should we introduce sub-groups or go with alphabetical order @spikymonkey?

@spikymonkey
Copy link
Contributor

I like the idea, should we introduce sub-groups or go with alphabetical order @spikymonkey?

Maybe alphabetical for now, since it's a fairly short list? We can always add sub groups later if we want to.

Adding stack as a suported property
@Albertoimpl
Copy link
Member Author

Done, thanks @spikymonkey!

Copy link
Contributor

@spikymonkey spikymonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks @Albertoimpl!

@Albertoimpl Albertoimpl merged commit c869626 into main Oct 3, 2023
1 check passed
@Albertoimpl Albertoimpl deleted the arios/stack-docs-update branch October 3, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants