Check volume requirement on all containers. #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppwfs
requested changes
Aug 6, 2024
| @@ -250,10 +251,7 @@ PodSpec createPodSpec(AppDeploymentRequest appDeploymentRequest) { | |||
| podSpec.withTolerations(this.deploymentPropertiesResolver.getTolerations(deploymentProperties)); | |||
|
|
|||
| // only add volumes with corresponding volume mounts | |||
There was a problem hiding this comment.
This comment needs to be moved to the new location of where we add volumes to volume mounts.
| public void deployWithVolumesAndVolumeMountsOnAdditionalContainer() throws Exception { | ||
| AppDefinition definition = new AppDefinition("app-test", null); | ||
| Map<String, String> props = new HashMap<>(); | ||
| props.put("spring.cloud.deployer.kubernetes.volumes", "[{name: 'config', configMap: {name: promtail-config, items: [{key: promtail.yaml, path: promtail.yaml}]}}]"); |
There was a problem hiding this comment.
Nitpick: Could we add more volumes so that we can make sure the correct one is returned?
|
One more request can we have a negative test? 🙏 |
Added negative test where one volume mount is absent.
Added a negative test |
cppwfs
added
the
type/forwardport
cppwfs
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volume was only checked on volume-mounts of main container.
In the case where volumes were defined for use on init-containers or additional-containers it was not added the list of volumes.
Now the volume is checked and added after all containers are known.
Fixes #454