-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect default values in docs (#4294) #4321
Conversation
Bumps `testcontainers.version` from 1.19.8 to 1.20.1. Updates `org.testcontainers:mockserver` from 1.19.8 to 1.20.1 - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.19.8...1.20.1) Updates `org.testcontainers:junit-jupiter` from 1.19.8 to 1.20.1 - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.19.8...1.20.1) --- updated-dependencies: - dependency-name: org.testcontainers:mockserver dependency-type: direct:development update-type: version-update:semver-minor - dependency-name: org.testcontainers:junit-jupiter dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…d#4317) Bumps [antora](https://gitlab.com/antora/antora) from 3.2.0-alpha.4 to 3.2.0-alpha.6. - [Changelog](https://gitlab.com/antora/antora/blob/main/CHANGELOG.adoc) - [Commits](https://gitlab.com/antora/antora/compare/v3.2.0-alpha.4...v3.2.0-alpha.6) --- updated-dependencies: - dependency-name: antora dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@springio/asciidoctor-extensions](https://github.com/spring-io/asciidoctor-extensions) from 1.0.0-alpha.10 to 1.0.0-alpha.13. - [Changelog](https://github.com/spring-io/asciidoctor-extensions/blob/main/CHANGELOG.adoc) - [Commits](spring-io/asciidoctor-extensions@v1.0.0-alpha.10...v1.0.0-alpha.13) --- updated-dependencies: - dependency-name: "@springio/asciidoctor-extensions" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--- updated-dependencies: - dependency-name: "@antora/collector-extension" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
That file is auto generated, so editing it directly is not the right way to do this |
Right. @555cider what seems to happen is that the default values in Line 99 in 57dd4f0
configprops file, change the default values in those @ConfigurationProperties classes to explicit values (you could add comments such as "5 * MINUTES" where helpful.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @555cider, please adjust the changes as described here: #4321 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @555cider - the changes look good; have you regenerated the configprops file with the new changes (in order to do that, remove any manual changes in the file and run ./mvnw clean install -Pdocs
locally and the file will be regenerated)? Also, please add your full name and surname with @author
tag in the javadocs of the classes you've modified and update the dates in the years in the license comment on top of the class to -2024
. Finally, could you submit your changes against the 4.1.x
branch instead of main
?
Fixes gh-4294. |
I have applied all the changes you requested except for the regeneration of the configprops file. I was unable to regenerate the file because it involves removing any manual changes and running Just in case, I've reverted the _configprops file back to its original state. Also, I accidentally merged the main branch while clicking around the site. I force pushed to clean up the git history, but if this action is not allowed, I will create a new pull request. In that case, I will modify the branch based on the "4.1.x" branch and submit the request. |
Thanks @555cider - waiting for the new PR. |
No description provided.