Localization #57
Localization #57
Conversation
…into localization
|
I should add more tests for this. |
| raise NotImplementedError | ||
|
|
||
|
|
||
| class File_C(Component): |
There was a problem hiding this comment.
Please can we change this to FileComponent?
| self.filename = filename | ||
|
|
||
|
|
||
| class Line_C(Component): |
| self.lineno = lineno | ||
|
|
||
|
|
||
| class Function_C(Component): |
| filename: File_C = None, | ||
| line_start: int = 0, | ||
| line_end: int = 0) -> None: | ||
| self.funcname = funcname |
There was a problem hiding this comment.
Prefer hidden variables (e.g., self.__funcname) over public variables (e.g., self.funcname). Use the @property decorator to ensure read-only (external) access to the variable.
| try: | ||
| loc = yaml.load(f) | ||
| except KeyError as err: | ||
| print('Error when importing', filename, '.', err) |
There was a problem hiding this comment.
Does this work? Prefer "foo {}; bar {}".format(x, y).
| except KeyError as err: | ||
| print('Error when importing', filename, '.', err) | ||
| raise IOError | ||
| return loc |
There was a problem hiding this comment.
What is the type of loc? Unless I've misunderstood, yaml.load(f) should return a dictionary? Does loc not need to be unpacked into a Localization object?
| Stores its internal data in a file | ||
| """ | ||
| with open(filename, "w") as f: | ||
| yaml.dump(self, f) |
There was a problem hiding this comment.
Prefer to dump relevant information to a dictionary rather than dumping the entire object, which may contain irrelevant and/or ephemeral information.
| import yaml | ||
|
|
||
| VERSION = "1.0" | ||
| G = TypeVar('G', bound=Component) |
There was a problem hiding this comment.
G and S are the same?
| granularity: Type[G], | ||
| version: str = VERSION) -> None: | ||
|
|
||
| self.mapping = mapping |
There was a problem hiding this comment.
Use hidden variables and properties.
No description provided.