isSuperTypeOf() returns IsSuperTypeOfResult

staabm · Nov 14, 2024 · e28fb5e · e28fb5e
1 parent 91239bd
commit e28fb5e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/DoctrineReflection/DoctrineResultObjectType.php b/src/DoctrineReflection/DoctrineResultObjectType.php
@@ -7,6 +7,7 @@
 use Doctrine\DBAL\Result;
 use PHPStan\ShouldNotHappenException;
 use PHPStan\TrinaryLogic;
+use PHPStan\Type\IsSuperTypeOfResult;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 
@@ -51,10 +52,10 @@ public function equals(Type $type): bool
         return parent::equals($type);
     }
 
-    public function isSuperTypeOf(Type $type): TrinaryLogic
+    public function isSuperTypeOf(Type $type): IsSuperTypeOfResult
     {
         if ($type instanceof self) {
-            return TrinaryLogic::createFromBoolean(
+            return IsSuperTypeOfResult::createFromBoolean(
                 $type->rowType !== null
                 && $this->rowType !== null
                 && $type->rowType->equals($this->rowType)

diff --git a/src/DoctrineReflection/DoctrineStatementObjectType.php b/src/DoctrineReflection/DoctrineStatementObjectType.php
@@ -7,6 +7,7 @@
 use Doctrine\DBAL\Statement;
 use PHPStan\ShouldNotHappenException;
 use PHPStan\TrinaryLogic;
+use PHPStan\Type\IsSuperTypeOfResult;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 
@@ -51,10 +52,10 @@ public function equals(Type $type): bool
         return parent::equals($type);
     }
 
-    public function isSuperTypeOf(Type $type): TrinaryLogic
+    public function isSuperTypeOf(Type $type): IsSuperTypeOfResult
     {
         if ($type instanceof self) {
-            return TrinaryLogic::createFromBoolean(
+            return IsSuperTypeOfResult::createFromBoolean(
                 $type->rowType !== null
                 && $this->rowType !== null
                 && $type->rowType->equals($this->rowType)

diff --git a/src/QueryReflection/QueryReflection.php b/src/QueryReflection/QueryReflection.php
@@ -206,7 +206,7 @@ public function isResolvable(Expr $queryExpr, Scope $scope): TrinaryLogic
         }
         $isStringOrMixed = $type->isSuperTypeOf(new StringType());
 
-        return $isStringOrMixed->negate();
+        return $isStringOrMixed->negate()->result;
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up @@
             }
             $isStringOrMixed = $type->isSuperTypeOf(new StringType());
-            return $isStringOrMixed->negate();
+            return $isStringOrMixed->negate()->result;
         }
         /**
@@ Expand Down @@