Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use base64 encoded JSON string of sort keys as pagination token #323

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix: use base64 encoded JSON string of sort keys as pagination token #323

merged 2 commits into from
Dec 13, 2024

Conversation

StijnCaerts
Copy link
Collaborator

@StijnCaerts StijnCaerts commented Dec 10, 2024 •
edited
Loading

Related Issue(s):

Description:
Use base64 encoded JSON string of sort keys as pagination token instead of comma separated string.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@StijnCaerts StijnCaerts linked an issue Dec 10, 2024 that may be closed by this pull request
Pagination fails when datetime is not set #322
Closed
@jonhealy1 jonhealy1 self-requested a review December 13, 2024 08:28
jonhealy1
jonhealy1 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@StijnCaerts StijnCaerts merged commit 7e848b4 into stac-utils:main Dec 13, 2024
15 checks passed
@StijnCaerts StijnCaerts deleted the fix/#322-pagination-token branch December 13, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhealy1 jonhealy1 jonhealy1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination fails when datetime is not set
2 participants
@StijnCaerts @jonhealy1