feat: add package-lock.json and add CI check #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamVerschueren
commented
Oct 9, 2024
| }, | ||
| "devDependencies": { | ||
| "npm": "10.2.3", |
There was a problem hiding this comment.
I install [email protected] (which is the one we use in WebContainer) so you don't have to install that version on your machine if you want to run the package:* scripts.
kirjavascript
approved these changes
Oct 9, 2024
Nemikolh
approved these changes
Oct 9, 2024
Comment on lines
+85
to
+87
| new Error( | ||
| `The \`package-lock.json\` is not in sync with the \`package.json\` for starter \`${name}\`.` | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
package-lock.jsonback. This PR addresses the cons that are discussed in #14.package-lock.jsonin EngineBlock projects, so we'd have to check that we don't end up adding those.package.jsonbut not thepackage-lock.json, and we don't have any CI checking that.package-lock.json, then installing dependencies becomes slower on StackBlitz that if we didn't have one (and were generating a new one on import).