Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tweaks #7

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Some tweaks #7

merged 2 commits into from
Aug 10, 2024

Conversation

danicheg
Copy link
Contributor

Several unsolicited tweaks that I accidentally noticed.

@stanch stanch merged commit ce36769 into stanch:master Aug 10, 2024
2 checks passed
@stanch
Copy link
Owner

stanch commented Aug 10, 2024

Thanks! Would it even have worked in JS without the %%%? I am guessing this warrants a new release?

@danicheg danicheg deleted the fix-shapeless-dep branch August 11, 2024 09:00
@danicheg
Copy link
Contributor Author

Would it even have worked in JS without the %%%?

Yeah, it's confusing because according to the CI, JS was building well 🤷🏻 Maybe it's because we define dependencies via crossProject(JSPlatform, JVMPlatform).setting. Anyway, I don't think we should supply a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danicheg @stanch