Geant4star integration #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before submitting PR#315 some code cleanup was performed (see note below). The fast jet directory was moved from StarGenerator/FastJetFilt to StarGenerator/FILT/FastJetFilt, to conform with the standard source tree layout for filters. 4f27034 625bbdd Conscript-standard directory rules allow one to specify include paths based on the module (StarGenerator) and package. The package is one directory beneath the module... before code cleanup this was the FastJetFilter directory. After cleanup, we have to apply the fast jet include path to all filters in the StarGenerator/FILT directory. ---- Note on the pp 200 HF filtered jet production. The production commenced with fast jet filter code built before code cleanup, based on the original location of the fast jet filter in the source tree.
klendathu2k
requested review from
genevb,
plexoos and
nigmatkulov
as code owners
klendathu2k
commented
Jul 13, 2022
| @@ -1211,6 +1211,7 @@ Bfc_st BFC[] = { // standard chains | |||
| {"McEvOut" ,"" ,"","StMcEvent,Tree" ,"","","Write StMcEvent to StTree",kFALSE}, | |||
| {"EvOut" ,"" ,"","Tree" ,"","","Write StEvent to StTree",kFALSE}, | |||
| {"GeantOut" ,"" ,"","Tree" ,"","","Write g2t tables to StTree",kFALSE}, | |||
| {"Geant4Out" ,"" ,"","Tree" ,"","","Write g2t tables to StTree from G4",kFALSE}, | |||
There was a problem hiding this comment.
Note: this chain option requires an update to StBFChain.cxx to add the StGeant4Maker into the tree, which must
wait for the integration of StGeant4Maker.
klendathu2k
commented
Jul 13, 2022
| {"stargen.util", "","", "gen_T,sim_T"/*+++*/, "", "libVMC.so,libStarGeneratorUtil.so,libMathMore.so","STAR Generator BASE",false}, | ||
| {"stargen.event","","", "gen_T,sim_T"/*+++*/, "", "libVMC.so,libStarGeneratorEvent.so,libMathMore.so","STAR Generator BASE",false}, | ||
| {"stargen.base", "","", "gen_T,sim_T"/*+++*/, "", "libVMC.so,libStarGeneratorBase.so,libMathMore.so","STAR Generator BASE",false}, | ||
| {"stargen", "","", "stargen.util,stargen.event,stargen.base"/*+++*/, "", "","STAR Generator BASE",false}, |
There was a problem hiding this comment.
Note: stargen loads have an unmet dependency in St_geant_Maker. Future commits will resolve this.
|
Jason and all, I see this one has been there for a while. As far as I see, all checks have passed, so the merge won't crash the running jobs? From your comments, Jason, there will still need other commits to resolve some of the dependencies. How should we proceed? Shall we just proceed to merge this PR (upon the sync with the latest main branch)? Thanks |
that is about to happen... Updated the setup and build scripts for the current pull request. The clhep version changed out from under us since the PR was made. Also, the build script now constructs root4star and starsim for general testing.
…2k/star-sw-1 into geant4star-integration
plexoos
reviewed
Sep 29, 2022
Comment on lines
+4
to
+5
| #module load root-6.24.00 | ||
| source /star/simu/simu/jwebb/ROOT/local/bin/thisroot.csh |
There was a problem hiding this comment.
Can you use the the ROOT installed by Spack instead? This should suffice:
module load star-env-X.Y.Z-root-6.V.W
...and you don't need to set the environment variables by hand as you do later in this file.
|
As I recall, I encountered problems when trying to compile against that
environment. Probably a missing ROOT feature... and/or needed to have a
more modern VMC version than was compiled. These are issues I would
prefer
to address in a future PR.
…On 2022-09-29 12:26, Dmitri Smirnov wrote:
@plexoos commented on this pull request.
-------------------------
In StRoot/StGeant4Maker/etc/setup [1]:
> +#module load root-6.24.00
+source /star/simu/simu/jwebb/ROOT/local/bin/thisroot.csh
Can you use the the ROOT installed by Spack instead? This should
suffice:
module load star-env-X.Y.Z-root-6.V.W
...and you don't need to set the environment variables by hand as you
do later in this file.
--
Reply to this email directly, view it on GitHub [2], or unsubscribe
[3].
You are receiving this because you authored the thread.Message ID:
***@***.***>
Links:
------
[1] #377 (comment)
[2]
#377 (review)
[3]
https://github.com/notifications/unsubscribe-auth/ANL4LVEHDMY7OI5EP7AX4ATWAW7KPANCNFSM53M2TREA
|
|
Superseded by #617 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following suggestions made in PR#311... splitting the geant4star pull request. First committing the changes to BigFullChain.h that define the chain options needed to load in geant4 and geant4vmc support libraries. Also adding the environment setup script and build script under StGeant4Maker/etc. And a test macro to load the libraries.
To compile:
$ source StRoot/StGeant4Maker/etc/setup
$ source StRoot/StGeant4Maker/etc/build
To test:
$ root.exe StRoot/StGeant4Maker/macros/loadGeant4Vmc.C
Result should be a successful load of the libraries.