Fix GCC warning: unused variables #395
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plexoos
force-pushed
the
pr/fix_unused
branch
from
3348730 to
a7acabc
Compare
plexoos
force-pushed
the
pr/fix_unused
branch
from
a7acabc to
64454ee
Compare
|
What's the criteria for commenting out lines vs. deleting them? |
When I see that a variable is "used" in some other already commented lines then I rather comment it out as well, otherwise remove. |
plexoos
force-pushed
the
pr/fix_unused
branch
2 times, most recently
from
dba2a5a to
f0d560d
Compare
|
Progress so far. This PR vs SL22 branch By warning: By package (40 with highest count selected, RTS and Jevp are simply disabled): |
plexoos
force-pushed
the
pr/fix_unused
branch
from
713d534 to
70c8904
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting rid of such warnings as
See #392 for motivation