Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fxt update #721

Merged
merged 11 commits into from
Dec 16, 2024
Merged

Fxt update #721

merged 11 commits into from
Dec 16, 2024

Conversation

klendathu2k
Copy link
Contributor

No description provided.

@genevb
Copy link
Contributor

genevb commented Dec 10, 2024

I see that the 2018 fixed target position was also modified. This may not be justified as yet. My understanding is that the beampipe was removed between 2018 and 2019 for the detector rollout and installation of the iTPC. As such, the 2018 position may be different relative to STAR from the 2019+ position. I understand that the 2018 FXT position of 200.7 was identified in Fig. 19, page 26 of this analysis note:
https://drupal.star.bnl.gov/STAR/system/files/Analysis_Note_for_Higher_Order_Cumulants_FXT_Au_Au_3_0_GeV.pdf

So we probably only want to adjust 2019-2021 geometries to use z = 200.0 cm for now.

@klendathu2k
Copy link
Contributor Author

klendathu2k commented Dec 10, 2024 via email

Copy link
Contributor

@genevb genevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@genevb
Copy link
Contributor

genevb commented Dec 15, 2024

LGTM.

Well.... better to understand the build failure before merging.

@klendathu2k
Copy link
Contributor Author

Build issue was a duplicate entry for y2024a coupled with hubris on my part not to compile locally before making the PR. Second entry should have been tagged as y2024b. Code compiles locally, so I expect this to compile on github.

@klendathu2k
Copy link
Contributor Author

All tests are passing, so hitting the shining green button.

@klendathu2k klendathu2k merged commit 0accbf9 into star-bnl:main Dec 16, 2024
148 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants