Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Bitget wallet is discovery #221

Closed
wants to merge 0 commits into from
Closed

Conversation

shuise
Copy link

@shuise shuise commented Mar 26, 2024

RT

@dan-ziv
Copy link
Contributor

dan-ziv commented Apr 15, 2024

Hey @shuise,
Please fix failed test.

@DetonateYin2077
Copy link

Hi @shuise ,
I noticed that you've added the Bitget Wallet configuration to the discovery.ts file. Much appreciate your work on this.

image

However, the test cases have not been updated to reflect this change. The length of discoveryWallets should now be 3, since the Bitget Wallet has been added.

image

To fix the failing test, the expected value should be updated from 2 to 3.

Please let me know if you have any other questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants