Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eip 6963 #244

Merged
merged 13 commits into from
Jul 9, 2024
Merged

feat: eip 6963 #244

merged 13 commits into from
Jul 9, 2024

Conversation

khanti42
Copy link
Contributor

@khanti42 khanti42 commented May 24, 2024

closes #254.

Copy link

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the implementation needed to update, as it is not working in 2 wallets case

packages/core/src/wallet/metamaskBridge.ts Outdated Show resolved Hide resolved
packages/core/src/wallet/metamaskBridge.ts Outdated Show resolved Hide resolved
packages/core/src/wallet/metamaskBridge.ts Outdated Show resolved Hide resolved
@khanti42 khanti42 marked this pull request as ready for review May 27, 2024 09:06
packages/core/.env.sample Outdated Show resolved Hide resolved
@khanti42 khanti42 force-pushed the feat/eip-6963 branch 4 times, most recently from d8b7cba to 67e0747 Compare July 3, 2024 11:35
@naorye2 naorye2 merged commit e11f822 into starknet-io:master Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update DetectMetaMaskProvider to Use EIP-6963 for Enhanced Multi-Wallet Support
5 participants