fix: Decouple Virtual Wallet Discovery in get-starknet
#280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple Virtual Wallet Discovery in
get-starknetSummary
This PR introduces a
discoverVirtualWalletsmethod to handle virtual wallet discovery asynchronously, decoupling it from the synchronousGetStarknet()function.Changes
discoverVirtualWalletsfor explicit async virtual wallet discovery.initiateVirtualWalletsto avoid redundanthasSupportcalls.Why
Users can still call
GetStarknet()with the current fire-and-forget behavior. However, this change allows developers to ensure the async discovery process is completed before callingGetStarknet()synchronously, giving more control over the workflow.