Fix detection of Abi version in contract with only constructor #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penovicp
approved these changes
Oct 6, 2024
ivpavici
reviewed
Oct 7, 2024
| (it) => it.type === 'function' && (it.inputs.length || it.outputs.length) | ||
| const testSubject = abi.find( | ||
| (it) => | ||
| (it.type === 'function' || it.type === 'constructor') && |
There was a problem hiding this comment.
no need to do it now, but later we can extract these comparisons somewhere to not have magic strings, since we have these same comparisons in a couple of more files cc @penovicp
ivpavici
approved these changes
Oct 7, 2024
|
🎉 This issue has been resolved in version 6.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Fixes detection of Abi version and closes #1242
RPC version (if applicable)
...
Usage related changes
No exception of new CallData in contracts without any function
Development related changes
Checklist: