refactor: parse int as number or big int #804
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development related changes
1.Use Number.isInteger to check if the input can be parsed as an integer, and if not, we parse it as a float.
2.Use Number(x) to convert the string to a number for checking integer type.
3.Split the condition and result into separate lines for improved readability.
4.Use Number.isSafeInteger to check if the parsed integer is within the safe integer range.
4.If it's a safe integer, we return it as a regular number; otherwise, we return it as a BigInt.
Checklist: