Update workload controller for new design #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
==========================================
- Coverage 12.84% 12.61% -0.24%
==========================================
Files 3 3
Lines 109 111 +2
==========================================
Hits 14 14
- Misses 94 96 +2
Partials 1 1
Continue to review full report at Codecov.
|
hossainemruz
force-pushed
the
workload-controller
branch
2 times, most recently
from
2eab3c4 to
79c9965
Compare
hossainemruz
force-pushed
the
workload-controller
branch
from
a5155c9 to
78c98f5
Compare
tamalsaha
reviewed
Feb 27, 2019
hossainemruz
force-pushed
the
workload-controller
branch
5 times, most recently
from
638e443 to
540dddc
Compare
6 tasks
hossainemruz
force-pushed
the
workload-controller
branch
from
107e1e3 to
d2c055c
Compare
hossainemruz
force-pushed
the
workload-controller
branch
from
d2c055c to
0bce5aa
Compare
hossainemruz
force-pushed
the
workload-controller
branch
from
0bce5aa to
124338d
Compare
tamalsaha
reviewed
Mar 21, 2019
| @@ -18,6 +18,9 @@ import ( | |||
|
|
|||
| func CreateOrPatchBackupSession(c cs.StashV1beta1Interface, meta metav1.ObjectMeta, transform func(bs *api.BackupSession) *api.BackupSession) (*api.BackupSession, kutil.VerbType, error) { | |||
| cur, err := c.BackupSessions(meta.Namespace).Get(meta.Name, metav1.GetOptions{}) | |||
| if err != nil { | |||
tamalsaha
approved these changes
Mar 21, 2019
tamalsaha
reviewed
Mar 21, 2019
tamalsaha
reviewed
Mar 21, 2019
| hostPath: | ||
| path: /data/stash-test/${TARGET_NAMESPACE}/${TARGET_KIND}/${TARGET_NAME} | ||
| storageSecretName: local-secret | ||
| schedule: "* * * * *" |
There was a problem hiding this comment.
Either single or double quote. Better stay consistent.
tamalsaha
reviewed
Mar 21, 2019
| service: | ||
| name: quick-postgres | ||
| port: 5432 | ||
| scheme: "http" |
There was a problem hiding this comment.
I usually avoid unnecessary quotes.
diptadas
reviewed
Mar 22, 2019
|
|
||
| // if there is more than one BackupConfiguration then return error | ||
| if len(result) > 1 { | ||
| var msg bytes.Buffer |
| return err | ||
| } | ||
|
|
||
| func (c *StashController) setBackupSessionFailed(backupSession *api_v1beta1.BackupSession, jobErr error) error { |
There was a problem hiding this comment.
use UpdatePostBackupStatus from status package
tamalsaha
pushed a commit
that referenced
this pull request
Mar 28, 2019
Closed
This was referenced Mar 28, 2019
Closed
tamalsaha
pushed a commit
to stashed/postgres
that referenced
this pull request
May 23, 2019
**Requirements** : - [x] Merge stashed/stash#673 to master - [x] Merge stashed/stash#675 to master - [x] Merge stashed/stash#691 - [x] Rebase against master **Fixed Issue** : - [x] Add `BackupSession Sidecar Controller` Controller - [x] Controller take backup
tamalsaha
pushed a commit
to stashed/docs
that referenced
this pull request
May 25, 2019
**Requirements** : - [x] Merge stashed/stash#673 to master - [x] Merge stashed/stash#675 to master - [x] Merge stashed/stash#691 - [x] Rebase against master **Fixed Issue** : - [x] Add `BackupSession Sidecar Controller` Controller - [x] Controller take backup
tamalsaha
pushed a commit
to stashed/apimachinery
that referenced
this pull request
Feb 16, 2020
**Requirements** : - [x] Merge stashed/stash#673 to master - [x] Merge stashed/stash#675 to master - [x] Merge stashed/stash#691 - [x] Rebase against master **Fixed Issue** : - [x] Add `BackupSession Sidecar Controller` Controller - [x] Controller take backup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements:
Tasks:
Update Restore Logic
Update Backup Logic
Update Workload Controllers
Fix ConfigMap lock deletion and RBAC stuff deletion logic
Ensure sidecar/init-container according to new design
Add new backup command (sagor is working)
Add new restore command
Add controller (possibly in different PR)