Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run one warning for variables #375

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Run one warning for variables #375

merged 1 commit into from
Jul 30, 2024

Conversation

tilen1976
Copy link
Contributor

  • Add function to calculate total number of fields for all variables with value
  • Refactor bool methods inline return
  • Use total num for variables in validator and percent calculation

@tilen1976 tilen1976 requested a review from a team as a code owner July 30, 2024 11:44
@tilen1976 tilen1976 added the refactoring Refactoring label Jul 30, 2024
mmwinther
mmwinther approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@mmwinther mmwinther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🙌

@tilen1976 tilen1976 merged commit c6efc9b into master Jul 30, 2024
16 checks passed
@tilen1976 tilen1976 deleted the fix/variables-validation-issues branch July 30, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmwinther mmwinther mmwinther approved these changes

Assignees
No one assigned
Labels
refactoring Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tilen1976 @mmwinther