Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change warning message for illegal shortnames #434

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Change warning message for illegal shortnames #434

merged 2 commits into from
Nov 11, 2024

Conversation

Jorgen-5
Copy link
Contributor

@Jorgen-5 Jorgen-5 commented Nov 8, 2024

  • Changed the message to reflect the actual regex
  • Added more tests to check different variable shortnames

@Jorgen-5 Jorgen-5 requested a review from a team as a code owner November 8, 2024 17:24
mmwinther
mmwinther approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@mmwinther mmwinther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍

@Jorgen-5 Jorgen-5 merged commit 6a72807 into master Nov 11, 2024
19 checks passed
@Jorgen-5 Jorgen-5 deleted the fix/change-warning-message branch November 11, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmwinther mmwinther mmwinther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jorgen-5 @mmwinther