Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make references to variables internal to graph more explicit #46

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

ssb-yib
Copy link
Collaborator

@ssb-yib ssb-yib commented Nov 5, 2024

Using "bare" references to vertex and edge attributes produced some R CMD check errors. These changes reduce ambiguity by indexing the vertices and edges explicitly.

Using "bare" references to vertex and edge attributes produced some R CMD check errors. These changes reduce ambiguity by indexing the vertices and edges explicitly.
@ssb-yib ssb-yib requested a review from sjentoft November 5, 2024 09:09
@sjentoft
Copy link
Collaborator

sjentoft commented Nov 5, 2024

I think there is also a "name" that needs a solution too.

Using "bare" references to vertex and edge attributes produced some R CMD check errors. These changes reduce ambiguity by indexing the vertices and edges explicitly.
@ssb-yib
Copy link
Collaborator Author

ssb-yib commented Nov 5, 2024

I think there is also a "name" that needs a solution too.

I fixed one name in 6e60583

Copy link
Collaborator

@sjentoft sjentoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ssb-yib ssb-yib merged commit c46bbac into develop Nov 7, 2024
1 check passed
@ssb-yib ssb-yib deleted the yib/fix-igraph-global branch November 7, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants