Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RC Start Hang #3598

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix RC Start Hang #3598

wants to merge 5 commits into from

Conversation

mvandeberg
Copy link
Contributor

@mvandeberg mvandeberg commented Feb 8, 2020 •
edited
Loading

Closes #3589 #3605

@mvandeberg mvandeberg requested a review from sgerbino February 8, 2020 00:19
sgerbino
sgerbino suggested changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@sgerbino sgerbino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but would be better if we created a define for the default initialized mana for future readability.

Suggestion: #define RC_PLUGIN_DEFAULT_INITIALIZED_MANA std::numeric_limits< int64_t >::max()

@mvandeberg mvandeberg requested a review from sgerbino February 11, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgerbino sgerbino Awaiting requested review from sgerbino

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RC Plugin Causing TestNet Hang
2 participants
@mvandeberg @sgerbino