-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup #24
base: main
Are you sure you want to change the base?
Cleanup #24
Conversation
We need to establish some tests (unit / integration / benchmark) so that we can check these PRs aren't messing with the code. |
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
All of the current tests assume data files. We need to make some similar tests with small data files we can host on the repo. |
Signed-off-by: nstarman <[email protected]>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
========================================
- Coverage 0.34% 0.32% -0.03%
========================================
Files 9 16 +7
Lines 864 929 +65
========================================
Hits 3 3
- Misses 861 926 +65 ☔ View full report in Codecov by Sentry. |
Suitable for squash merge! |
Added type hints and docstrings.
Removed extraneous code.
Refactored the layout of some modules.
Moved the tests.
Requires #25