This repository has been archived by the owner on Jun 4, 2023. It is now read-only.
Error handling in setupSonos() - Proposal #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* moved setup code from anonymous function into setupSonos() * added argument "--devices" - takes comma-separated list of IP[:Port]
…vice throws error * individual setups should run in a domain, so we can catch errors individually
* fixed indents to two spaces * changed formatting of string concatination * slight change of error messages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal how error handling can be handled in AirSonos.
I don't know if there is a "more correct" way to do this or if there are any pitfalls i am not aware of. Still trying to figure this stuff out.
This pull requests includes also pull request #88 ("adding support for manual setup of Sonos devices")