fix: snapshot drift issue #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the time calc there may be subtle drift if our date-fns parsing "copies" certain elements from the runtime clock when they're not defined in our date strings
|
Preview build deployed to: https://ead93e50.genocide-club.pages.dev |
|
Preview build deployed to: https://e8a5cf17.genocide-club.pages.dev |
|
Preview build deployed to: https://c22baa5c.genocide-club.pages.dev |
|
Preview build deployed to: https://d6c412ef.genocide-club.pages.dev |
|
Preview build deployed to: https://2b3ec6c9.genocide-club.pages.dev |
sterlingwes
commented
Jan 29, 2024
| @@ -47,7 +49,7 @@ export const getTimeline = ({ | |||
| svgDomain: ReturnType<typeof getSvgDomain>; | |||
| dataFetcher?: typeof getData; | |||
| }) => { | |||
| const { firstDateVal, realTimeDuration } = getTimelineBounds(); | |||
| const { firstDateVal, realTimeDuration } = getTimelineBounds(dataFetcher); | |||
There was a problem hiding this comment.
this was the issue - was importing from my local file so the snapshot included Jan date range whereas our test fixture only goes to the end of 2023
|
Preview build deployed to: https://e1b69ade.genocide-club.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason it's flakey