Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ghc 9.12 + hashable 1.5 #182

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Dec 10, 2024

Fixes #183

@stevenfontanella
Copy link
Owner

Thanks for opening! I'll take a look this weekend.

@erikd
Copy link
Contributor Author

erikd commented Dec 16, 2024

@stevenfontanella Ping?

@stevenfontanella stevenfontanella changed the title Support ghc 9.12 Support ghc 9.12 + hashable 1.5 Dec 16, 2024
@stevenfontanella stevenfontanella merged commit dfb7a61 into stevenfontanella:master Dec 16, 2024
13 checks passed
@erikd
Copy link
Contributor Author

erikd commented Dec 16, 2024

@stevenfontanella Would really appreciate a Hacakge metadata edit as well

@stevenfontanella
Copy link
Owner

Yes, will create a release later tonight.

@erikd
Copy link
Contributor Author

erikd commented Dec 17, 2024

Unless you have other changes that warrant a release, the only changes in this PR are to dependency upper bounds and they can be fixed with metadata update. I am a Hackage Trustee and I can even do them for you if you would like,

stevenfontanella added a commit that referenced this pull request Dec 17, 2024
@stevenfontanella
Copy link
Owner

Released:

Re: a metadata-only update for this change: so far I prefer patch releases for changes like this. I feel that it's better since it removes the time element, e.g. if we didn't make a patch release here, the question "does microlens-pro 0.2.0.1 support GHC 9.12?" doesn't have a clear answer; it depends on when that library was installed. Is there any downside to making a patch release in this case instead of a metadata-only update? If it's not a common practice among other libraries, I can just adopt the more common practice too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

microlens-platform: support hashable 1.5.0.0, get back in stackage
2 participants