Hessian preconditioner wrappers #410
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskooi
reviewed
Aug 31, 2021
| d->o = this; d->f = f; d->f_data = f_data; d->mf = NULL; d->vf = NULL; | ||
| d->pf = pf; | ||
| d->munge_destroy = md; d->munge_copy = mc; | ||
| printf("ALEC\n"); |
There was a problem hiding this comment.
Looks like this line is an artifact of some debugging?
stevengj
reviewed
Sep 1, 2021
| static void pfunc_python(unsigned n, const double *x, const double *v, double *vpre, void *f) | ||
| { | ||
| npy_intp sz = npy_intp(n), sz0 = 0, stride1 = sizeof(double); | ||
| PyObject *xpy = PyArray_New(&PyArray_Type, 1, &sz, NPY_DOUBLE, &stride1, |
There was a problem hiding this comment.
Seems like these calls are equivalent to calling PyArray_SimpleNewFromData?
stevengj
reviewed
Sep 1, 2021
| const_cast<double*>(v), // not NPY_WRITEABLE | ||
| 0, NPY_ARRAY_C_CONTIGUOUS | NPY_ARRAY_ALIGNED, NULL); | ||
| PyObject *vprepy = vpre | ||
| ? PyArray_SimpleNewFromData(1, &sz, NPY_DOUBLE, vpre) |
There was a problem hiding this comment.
Shouldn't vpre always be non-NULL here?
|
hello @smartalecH, any news on this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #177
There's still an issue with the python wrappers. Seems to be passing the wrong number of arguments:
Any ideas what might be wrong?