Update package authors, homepages and descriptions #74
Conversation
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 22 22
Lines 185 185
Branches 42 42
=====================================
Hits 185 185Continue to review full report at Codecov.
|
| @@ -23,5 +22,9 @@ | |||
| }, | |||
| "main": "lib/index.js", | |||
| "module": "es/index.js", | |||
| "author": "Steve Sims" | |||
| "author": "Toby Brancher", | |||
components/table/package.json
Outdated
| @@ -24,9 +24,10 @@ | |||
| "main": "lib/index.js", | |||
| "module": "es/index.js", | |||
| "author": "Tarandeep Singh Chauhan", | |||
There was a problem hiding this comment.
table was originally written by me
package.json
Outdated
| @@ -146,6 +146,7 @@ | |||
| "url": "https://github.com/stevesims/govuk-frederic.git" | |||
| }, | |||
| "author": "Steve Sims", | |||
| "contributors": ["Tarandeep Singh Chauhan", "Gavin Orland", "Toby Brancher"], | |||
There was a problem hiding this comment.
I'd be inclined to have the author as The govuk-frederic authors and then list us all as contributors
We should also add Alasdair Mcleay, Mark Chambers, Jonathan Sheldrake, and Simon Moore to the contributors list as well
There was a problem hiding this comment.
👍 Have added these in alphabetical order.
components/object-table/package.json
Outdated
| @@ -23,10 +23,11 @@ | |||
| }, | |||
| "main": "lib/index.js", | |||
| "module": "es/index.js", | |||
| "author": "Gavin Orland", | |||
| "author": "Toby Brancher", | |||
There was a problem hiding this comment.
this one was me too, with contributions by Toby
components/arrow-left/package.json
Outdated
| @@ -23,10 +23,11 @@ | |||
| }, | |||
| "main": "lib/index.js", | |||
| "module": "es/index.js", | |||
| "author": "Tarandeep Singh Chauhan", | |||
| "author": "Steve Sims", | |||
There was a problem hiding this comment.
I think this one was Mark Chambers
components/open-button/package.json
Outdated
| @@ -22,10 +22,11 @@ | |||
| }, | |||
| "main": "lib/index.js", | |||
| "module": "es/index.js", | |||
| "author": "Tarandeep Singh Chauhan", | |||
| "author": "Steve Sims", | |||
| @@ -22,10 +22,11 @@ | |||
| }, | |||
| "main": "lib/index.js", | |||
| "module": "es/index.js", | |||
| "author": "Tarandeep Singh Chauhan", | |||
| "author": "Steve Sims", | |||
| @@ -23,10 +23,11 @@ | |||
| }, | |||
| "main": "lib/index.js", | |||
| "module": "es/index.js", | |||
| "author": "Tarandeep Singh Chauhan", | |||
| "author": "Steve Sims", | |||
There was a problem hiding this comment.
this one might be me - can't remember exactly - plain "The govuk-frederic authors" may be best
components/result-count/package.json
Outdated
| @@ -23,10 +23,11 @@ | |||
| }, | |||
| "main": "lib/index.js", | |||
| "module": "es/index.js", | |||
| "author": "Tarandeep Singh Chauhan", | |||
| "author": "Steve Sims", | |||
There was a problem hiding this comment.
as with many others, a generic authors may be best here
components/spinner/package.json
Outdated
| @@ -19,10 +19,11 @@ | |||
| }, | |||
| "main": "lib/index.js", | |||
| "module": "es/index.js", | |||
| "author": "Tarandeep Singh Chauhan", | |||
| "author": "Steve Sims", | |||
|
Thanks Steve - I'll work my way through these. I put myself down as a contributor quite often btw because I wrote a lot of the tests. |
gavinorland
dismissed
stevesims’s stale review
Each point has now been actioned.
Here's a start, at least, on updating these various packages, addressing #54. I've provided basic descriptions of each component - open to change. Also tried to credit authors correctly, but may have this wrong - in particularly may have understated @Loque-'s contributions because I'm not aware of what he did. Open to ideas on this.
Just waiting for @taranchauhan to claim any credits, I think!
Add contributors to all components and remove private: false duplication
gavinorland
force-pushed
the
feature/package-info
branch
from
8ad9832 to
b39fec9
Compare
Here's a start, at least, on updating these various packages, addressing #54. I've provided basic descriptions of each component - open to change. Also tried to credit authors correctly, but may have this wrong - in particularly may have understated @Loque-'s contributions because I'm not aware of what he did. Open to ideas on this - open to direct commits, too!