Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2c::new remap #520

Merged
merged 3 commits into from
Dec 15, 2024
Merged

I2c::new remap #520

merged 3 commits into from
Dec 15, 2024

Conversation

burrbull
Copy link
Member

No description provided.

@burrbull
Copy link
Member Author

@pdgilbert Test this yet one time.

@burrbull burrbull marked this pull request as ready for review December 15, 2024 06:31
@pdgilbert
Copy link

Ok. I updated to new rmp-new commit:

Updating stm32f1xx-hal v0.10.0 (https://github.com/stm32-rs/stm32f1xx-hal?branch=rmp-new#04b84469) -> #d9f7eab0

and re-ran my example test with success. I also ran a much larger set of example tests with 60 of 80 passing. That is pretty good, since I am still cleaning up many of the tests in the switch to eh-1. (It is up from 5 of 80 a few days ago.) The CI for these is at https://github.com/pdgilbert/rust-integration-testing/actions. The overall coverage of my examples may not be very good, but I think it is pretty good for I2C. (So I give an approving review.) I will do some hardware run testing soon.

Copy link

@pdgilbert pdgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested I2C changes on several examples and they work well.

@burrbull burrbull merged commit 5fc8b99 into master Dec 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants