Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix minor bug in FPU MUL instruction #1028

Merged
merged 4 commits into from
Sep 21, 2024
Merged

🐛 fix minor bug in FPU MUL instruction #1028

merged 4 commits into from
Sep 21, 2024

Conversation

stnolting
Copy link
Owner

@stnolting stnolting commented Sep 20, 2024

Fix invalid instruction logic (if any operand is sNAN).

Bug identified by @racodond in #1024.

@mikaelsky, maybe this is also interesting for you 😉

@stnolting stnolting added bug Something isn't working as expected HW Hardware-related labels Sep 20, 2024
@stnolting stnolting self-assigned this Sep 20, 2024
@stnolting stnolting marked this pull request as ready for review September 20, 2024 19:43
@stnolting stnolting merged commit 6619eae into main Sep 21, 2024
10 checks passed
@stnolting stnolting deleted the fpu_mul_snan_fix branch September 21, 2024 09:40
@mikaelsky
Copy link
Collaborator

Interesting.. wonder why it was caught by the compliance coverage test. Will add it to my internal test list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected HW Hardware-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants