Added an option to disable Locale listener #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,6 +30,7 @@ public function getConfigTreeBuilder() | |||
| ->booleanNode('translation_fallback')->defaultFalse()->end() | |||
| ->booleanNode('persist_default_translation')->defaultFalse()->end() | |||
| ->booleanNode('skip_translation_on_load')->defaultFalse()->end() | |||
| ->booleanNode('disable_locale_listener')->defaultFalse()->end() | |||
There was a problem hiding this comment.
the double negation is weird. I would use use_request_locale instead, defaulting to true
|
@romaricdrigon are you still interested in this feature ? If yes, please update it based on the feedback I gave you previously, and please rebase it to fix conflicts |
|
I can continue the work if needed. I definitively need this feature |
|
I was not sure anyone but me was needing that one. Sure I will work on it. |
|
Definitely a must have 👍 |
|
Hi all, |
|
Oh yeah! can't wait! |
|
Ping @stof : this can be merged IMO ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In some case, using the Symfony2 locale (for example from the Request) to automatically filter entities using the
Translatableextension can lead to unwanted results.I came across such case in an application where the locale was already managed explicitly.
In this PR, we create an optional
disable_locale_listeneroption. The default value istrue, so there are no BC break.