Add PHPStan #468
Merged
Add PHPStan #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yguedidi
commented
Dec 9, 2023
yguedidi
commented
Dec 9, 2023
| @@ -14,13 +15,21 @@ | |||
| * Sets the username from the security context by listening on kernel.request | |||
| * | |||
| * @author Christophe Coevoet <[email protected]> | |||
| * | |||
| * @phpstan-template T of Loggable|object | |||
yguedidi
commented
Dec 9, 2023
| @@ -31,11 +32,13 @@ public function getName() | |||
| } | |||
|
|
|||
| /** | |||
| * @return ?string | |||
| * @return int|null | |||
There was a problem hiding this comment.
covariance with interface
stof
requested changes
Dec 11, 2023
| @@ -14,13 +15,21 @@ | |||
| * Sets the username from the security context by listening on kernel.request | |||
| * | |||
| * @author Christophe Coevoet <[email protected]> | |||
| * | |||
| * @phpstan-template T of Loggable|object | |||
There was a problem hiding this comment.
Loggable|object is the same than object
There was a problem hiding this comment.
used the same definition as in LoggableListener, so what should I do here?
There was a problem hiding this comment.
Either leave it as is or just make it T of object. Gedmo\Loggable\Loggable is an optional marker interface folks can use in their applications if they want to mark their models as loggable, but nothing requires implementing it and the only references to it in the library are template annotations.
tests/DependencyInjection/StofDoctrineExtensionsExtensionTest.php
Outdated
Show resolved
Hide resolved
tests/DependencyInjection/StofDoctrineExtensionsExtensionTest.php
Outdated
Show resolved
Hide resolved
yguedidi
force-pushed
the
add-phpstan
branch
from
cfeb7f6 to
252bd9b
Compare
stof
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.