Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenShift console timestamp component #4117

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

KevinFCormier
Copy link
Contributor

@KevinFCormier KevinFCormier commented Nov 29, 2024

Makes the <Timestamp /> component from OpenShift console available and simplifies the current mechanism for using console dynamic plugin SDK hooks and components while maintaining the ability to run in standalone mode.

The <Timestamp /> component gives us an easy way to have consistent display of timestamps that are localized.

Placeholder for standalone dev mode:
image

Demonstrating translated date/time string (French) and tooltip, with icon removed:
image

Relative time display (once the current bug is implemented):
image

TODOs:

  • Implement a simplified version of the component for standalone development use
  • Implement a wrapper component to handle removing the icon (which we will not want to use in a table context)
  • Contribute a fix for the broken relative string support (see draft PR Fix Timestamp relative display openshift/console#14555)

@vishsanghishetty
Copy link
Contributor

@KevinFCormier, thanks for making the changes, these look good to me

@vishsanghishetty
Copy link
Contributor

vishsanghishetty commented Dec 12, 2024

@KevinFCormier, please let me know what you think of the to-dos implementation

@KevinFCormier KevinFCormier force-pushed the use-ocp-timestamp-component branch from fe49550 to 051b000 Compare December 12, 2024 19:17
@vishsanghishetty
Copy link
Contributor

@KevinFCormier I just updated with a date formatting function.

@KevinFCormier KevinFCormier force-pushed the use-ocp-timestamp-component branch from 85986b6 to 2406d82 Compare December 18, 2024 13:59
@KevinFCormier KevinFCormier changed the title WIP Use OpenShift console timestamp component Use OpenShift console timestamp component Dec 18, 2024
@KevinFCormier
Copy link
Contributor Author

Thanks @vishsanghishetty
I made a couple small changes like using en-US instead of en-GB and making "09:30 AM" display as "9:30 AM" without the leading zero.

@KevinFCormier
Copy link
Contributor Author

/cc @Randy424

@openshift-ci openshift-ci bot requested a review from Randy424 December 18, 2024 14:00
Randy424
Randy424 previously approved these changes Dec 19, 2024
Copy link
Contributor

@Randy424 Randy424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Randy424
Copy link
Contributor

Randy424 commented Dec 19, 2024

/hold

Holding for development train.

@vishsanghishetty
Copy link
Contributor

@KevinFCormier and @Randy424 please review, reverted the changes in ManagedClusters component

@KevinFCormier
Copy link
Contributor Author

/lgtm

Copy link

openshift-ci bot commented Dec 19, 2024

@KevinFCormier: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
17.2% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

Copy link

openshift-ci bot commented Dec 19, 2024

@KevinFCormier: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-tests-sonarcloud 2087106 link true /test unit-tests-sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Randy424
Copy link
Contributor

Randy424 commented Dec 19, 2024

Will re-review once this goes green.
Assuming we're ok with the test coverage, I think this will still need to be merged with an override. @KevinFCormier

@Randy424
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 19, 2024
Copy link

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier, Randy424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KevinFCormier,Randy424]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Randy424
Copy link
Contributor

/unhold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants