-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OpenShift console timestamp component #4117
base: main
Are you sure you want to change the base?
Use OpenShift console timestamp component #4117
Conversation
@KevinFCormier, thanks for making the changes, these look good to me |
@KevinFCormier, please let me know what you think of the to-dos implementation |
fe49550
to
051b000
Compare
@KevinFCormier I just updated with a date formatting function. |
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
85986b6
to
2406d82
Compare
Thanks @vishsanghishetty |
/cc @Randy424 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold Holding for development train. |
Signed-off-by: vsanghishetty <[email protected]>
@KevinFCormier and @Randy424 please review, reverted the changes in |
/lgtm |
@KevinFCormier: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Quality Gate failedFailed conditions |
@KevinFCormier: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KevinFCormier, Randy424 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Makes the
<Timestamp />
component from OpenShift console available and simplifies the current mechanism for using console dynamic plugin SDK hooks and components while maintaining the ability to run in standalone mode.The
<Timestamp />
component gives us an easy way to have consistent display of timestamps that are localized.Placeholder for standalone dev mode:
Demonstrating translated date/time string (French) and tooltip, with icon removed:
Relative time display (once the current bug is implemented):
TODOs: