Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-19346: Enable 4/5 CPN to Cluster Details Form #4146

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ammont82
Copy link
Contributor

Copy link

openshift-ci bot commented Dec 11, 2024

Hi @ammont82. Thanks for your PR.

I'm waiting for a stolostron member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment on lines 42 to 43
workerAgents: 0
{{#if ai.controlPlaneAgents}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for switch statement. A simple

Suggested change
workerAgents: 0
{{#if ai.controlPlaneAgents}}
workerAgents: 0
controlPlaneAgents: {{{ai.controlPlaneAgents}}}

will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem is that controlPlaneAgents is an string and we need a number

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after fixing openshift-assisted/assisted-installer-ui#2727, we will have a number here.

also cim-template.hbs needs to be updated.

also in order to make the yaml editor -> UI form sync work, we need to update https://github.com/stolostron/console/blob/main/frontend/src/routes/Infrastructure/Clusters/ManagedClusters/CreateCluster/components/assisted-installer/DetailsForm.tsx#L138-L151

by adding the controlPlaneCount

controlPlaneCount: { path: 'AgentClusterInstall[0].spec.provisionRequirements.controlPlaneAgents' },

Signed-off-by: Montse Ortega <[email protected]>
Copy link

openshift-ci bot commented Dec 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82
Once this PR has been reviewed and has the lgtm label, please ask for approval from rawagner. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants