-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-19346: Enable 4/5 CPN to Cluster Details Form #4146
base: main
Are you sure you want to change the base?
MGMT-19346: Enable 4/5 CPN to Cluster Details Form #4146
Conversation
Signed-off-by: Montse Ortega <[email protected]>
Hi @ammont82. Thanks for your PR. I'm waiting for a stolostron member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
workerAgents: 0 | ||
{{#if ai.controlPlaneAgents}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for switch statement. A simple
workerAgents: 0 | |
{{#if ai.controlPlaneAgents}} | |
workerAgents: 0 | |
controlPlaneAgents: {{{ai.controlPlaneAgents}}} |
will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem is that controlPlaneAgents is an string and we need a number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after fixing openshift-assisted/assisted-installer-ui#2727, we will have a number here.
also cim-template.hbs
needs to be updated.
also in order to make the yaml editor -> UI form sync work, we need to update https://github.com/stolostron/console/blob/main/frontend/src/routes/Infrastructure/Clusters/ManagedClusters/CreateCluster/components/assisted-installer/DetailsForm.tsx#L138-L151
by adding the controlPlaneCount
controlPlaneCount: { path: 'AgentClusterInstall[0].spec.provisionRequirements.controlPlaneAgents' },
Signed-off-by: Montse Ortega <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ammont82 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to https://issues.redhat.com/browse/MGMT-19346
Need this PR to work: openshift-assisted/assisted-installer-ui#2727