Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support booleanish schemas & represent additional{Items,Properties} #31

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Jan 22, 2024

This PR introduces 2 changes:

  • additionalProperties and additionalItems keywords are now considered as schemas
  • a special BooleanishNode node type to support true/false schemas

You can see the integration live here stoplightio/json-schema-viewer#249

@P0lip P0lip self-assigned this Jan 22, 2024
@P0lip P0lip force-pushed the feat/additional-props branch from 48dde2e to 45535c1 Compare January 22, 2024 11:15
@P0lip P0lip changed the title feat: support booleanish schemas & additionalProperties feat: support booleanish schemas & represent additional{Items,Properties} Jan 22, 2024
@P0lip P0lip marked this pull request as ready for review January 22, 2024 15:54
@P0lip P0lip requested review from a team and rainum and removed request for a team January 22, 2024 15:59
Copy link

@billiegoose billiegoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P0lip P0lip merged commit 8300b12 into master Jan 23, 2024
3 checks passed
@P0lip P0lip deleted the feat/additional-props branch January 23, 2024 10:22
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants