chore: SIGNAL-7217 increase timeout for Task.await_many to account for 15 sec DB timeouts + buffer #112
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r 15 sec DB timeouts + buffer
btkostner
requested changes
Oct 22, 2024
btkostner
approved these changes
Oct 23, 2024
seungjinstord
pushed a commit
that referenced
this pull request
Oct 23, 2024
An automated release has been created for you. --- ## [3.4.1](v3.4.0...v3.4.1) (2024-10-23) ### Miscellaneous * SIGNAL-7217 increase timeout for Task.await_many to account for 15 sec DB timeouts + buffer ([#112](#112)) ([38ab6fc](38ab6fc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
SIGNAL-7217
Checklist
Problem
Load testing in staging showed that sometimes the event handlers processed work past the default 5 second timeout of
Task.await_many, therefore timing out. It's not frequent, but still significant, and an additional timeout to worry about.Details
Giving it
:infinitytimeout because it is well beyond the 15 second DB connection timeout, and also past the default 60 sec API call timeouts from HTTPoison or 30 second socket timeout for Req/finch timeout.That way there's at least a ceiling, but still enough time to do work without worrying about a 5 second timeout.